diff options
author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2020-05-02 12:50:44 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-05-02 12:50:44 -0400 |
commit | 6c341a13d813fc63b76fbbffe7920eeaf116d3a8 (patch) | |
tree | df6f10e3e68bd22e50731af94fe5de328fe2a1da /ext/bg/js | |
parent | cae6b657ab418a1cafedcb1cf72d0e793fa5178b (diff) |
Refactor frontend API classes (#482)
* Mark functions as private
* Remove constructor side effects
* Use safer handler invocation
* Mark functions as private
* Mark fields as private
* Update BackendApiForwarder public API
Diffstat (limited to 'ext/bg/js')
-rw-r--r-- | ext/bg/js/backend-api-forwarder.js | 6 | ||||
-rw-r--r-- | ext/bg/js/backend.js | 3 |
2 files changed, 5 insertions, 4 deletions
diff --git a/ext/bg/js/backend-api-forwarder.js b/ext/bg/js/backend-api-forwarder.js index 93db77d7..4ac12730 100644 --- a/ext/bg/js/backend-api-forwarder.js +++ b/ext/bg/js/backend-api-forwarder.js @@ -17,11 +17,11 @@ class BackendApiForwarder { - constructor() { - chrome.runtime.onConnect.addListener(this.onConnect.bind(this)); + prepare() { + chrome.runtime.onConnect.addListener(this._onConnect.bind(this)); } - onConnect(port) { + _onConnect(port) { if (port.name !== 'backend-api-forwarder') { return; } let tabId; diff --git a/ext/bg/js/backend.js b/ext/bg/js/backend.js index 8a8f00eb..2fce4be9 100644 --- a/ext/bg/js/backend.js +++ b/ext/bg/js/backend.js @@ -70,7 +70,8 @@ class Backend { this.popupWindow = null; - this.apiForwarder = new BackendApiForwarder(); + const apiForwarder = new BackendApiForwarder(); + apiForwarder.prepare(); this.messageToken = yomichan.generateId(16); |