diff options
author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2020-12-20 13:59:30 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-12-20 13:59:30 -0500 |
commit | 4f6309842f0926edb90907a3502c36ead465fc42 (patch) | |
tree | a5c4ef5d3be20958e111de640d4064be8ac8e99d /ext/bg/js/settings2 | |
parent | 7dd06e1a64bf563ac083ab2e3ca45fb71ed40a8b (diff) |
Dictionary display updates (#1146)
* Display dictionary-list as flex
* Move styles
* Move enabled toggle
* Update details
* Disable sorting based on priority
* Update styles
* Update title color when disabled
* Update display style of secondary search dictionaries
Diffstat (limited to 'ext/bg/js/settings2')
-rw-r--r-- | ext/bg/js/settings2/secondary-search-dictionary-controller.js | 16 |
1 files changed, 14 insertions, 2 deletions
diff --git a/ext/bg/js/settings2/secondary-search-dictionary-controller.js b/ext/bg/js/settings2/secondary-search-dictionary-controller.js index d3820364..8b6ea9d9 100644 --- a/ext/bg/js/settings2/secondary-search-dictionary-controller.js +++ b/ext/bg/js/settings2/secondary-search-dictionary-controller.js @@ -24,6 +24,7 @@ class SecondarySearchDictionaryController { this._settingsController = settingsController; this._getDictionaryInfoToken = null; this._container = null; + this._eventListeners = new EventListenerCollection(); } async prepare() { @@ -37,6 +38,8 @@ class SecondarySearchDictionaryController { // Private async _onDatabaseUpdated() { + this._eventListeners.removeAllEventListeners(); + const token = {}; this._getDictionaryInfoToken = token; const dictionaries = await this._settingsController.getDictionaryInfo(); @@ -44,18 +47,27 @@ class SecondarySearchDictionaryController { this._getDictionaryInfoToken = null; const fragment = document.createDocumentFragment(); - for (const {title} of dictionaries) { + for (const {title, revision} of dictionaries) { const node = this._settingsController.instantiateTemplate('secondary-search-dictionary'); fragment.appendChild(node); - const nameNode = node.querySelector('.dictionary-name'); + const nameNode = node.querySelector('.dictionary-title'); nameNode.textContent = title; + const versionNode = node.querySelector('.dictionary-version'); + versionNode.textContent = `rev.${revision}`; + const toggle = node.querySelector('.dictionary-allow-secondary-searches'); toggle.dataset.setting = ObjectPropertyAccessor.getPathString(['dictionaries', title, 'allowSecondarySearches']); + this._eventListeners.addEventListener(toggle, 'settingChanged', this._onEnabledChanged.bind(this, node), false); } this._container.textContent = ''; this._container.appendChild(fragment); } + + _onEnabledChanged(node, e) { + const {detail: {value}} = e; + node.dataset.enabled = `${value}`; + } }
\ No newline at end of file |