Json schema profile conditions (#758)

* Add clearCache function

* Add upgrade

* Use schema-based profile condition validation

* Update profile conditions settings controller

* Remove unnecessary async

* Remove old

* Remove unused templates

1 files changed, 18 insertions, 23 deletions

diff --git a/ext/bg/js/settings/profiles.js b/ext/bg/js/settings/profiles.js
index 2449ab44..c1961e20 100644
--- a/ext/bg/js/settings/profiles.js
+++ b/ext/bg/js/settings/profiles.js
@@ -16,17 +16,15 @@
  */
 
 /* global
- * ConditionsUI
- * conditionsClearCaches
- * profileConditionsDescriptor
- * profileConditionsDescriptorPromise
+ * ProfileConditionsUI
+ * api
  * utilBackgroundIsolate
  */
 
 class ProfileController {
     constructor(settingsController) {
         this._settingsController = settingsController;
-        this._conditionsContainer = null;
+        this._profileConditionsUI = new ProfileConditionsUI(settingsController);
     }
 
     async prepare() {
@@ -49,8 +47,11 @@ class ProfileController {
     // Private
 
     async _onOptionsChanged() {
+        const {modifiers} = await api.getEnvironmentInfo();
+        this._profileConditionsUI.setKeyInfo(modifiers.separator, modifiers.keys);
+
         const optionsFull = await this._settingsController.getOptionsFullMutable();
-        await this._formWrite(optionsFull);
+        this._formWrite(optionsFull);
     }
 
     _tryGetIntegerValue(selector, min, max) {
@@ -78,7 +79,7 @@ class ProfileController {
         profile.name = $('#profile-name').val();
     }
 
-    async _formWrite(optionsFull) {
+    _formWrite(optionsFull) {
         const currentProfileIndex = this._settingsController.profileIndex;
         const profile = optionsFull.profiles[currentProfileIndex];
 
@@ -91,23 +92,17 @@ class ProfileController {
 
         $('#profile-name').val(profile.name);
 
-        if (this._conditionsContainer !== null) {
-            this._conditionsContainer.cleanup();
-        }
+        this._refreshProfileConditions(optionsFull);
+    }
+
+    _refreshProfileConditions(optionsFull) {
+        this._profileConditionsUI.cleanup();
+
+        const profileIndex = this._settingsController.profileIndex;
+        if (profileIndex < 0 || profileIndex >= optionsFull.profiles.length) { return; }
 
-        await profileConditionsDescriptorPromise;
-        this._conditionsContainer = new ConditionsUI.Container(
-            profileConditionsDescriptor,
-            'popupLevel',
-            profile.conditionGroups,
-            $('#profile-condition-groups'),
-            $('#profile-add-condition-group')
-        );
-        this._conditionsContainer.save = () => {
-            this._settingsController.save();
-            conditionsClearCaches(profileConditionsDescriptor);
-        };
-        this._conditionsContainer.isolate = utilBackgroundIsolate;
+        const {conditionGroups} = optionsFull.profiles[profileIndex];
+        this._profileConditionsUI.prepare(conditionGroups);
     }
 
     _populateSelect(select, profiles, currentValue, ignoreIndices) {