aboutsummaryrefslogtreecommitdiff
path: root/ext/bg/js/settings/dictionary-controller.js
diff options
context:
space:
mode:
authortoasted-nutbread <toasted-nutbread@users.noreply.github.com>2021-01-23 21:07:45 -0500
committerGitHub <noreply@github.com>2021-01-23 21:07:45 -0500
commit9fbdb9757b22c2bb9afe5061137bfe4b3b755e91 (patch)
treeb7d3e9111b621ca2bf81f0c8023a433b64e9f055 /ext/bg/js/settings/dictionary-controller.js
parent85c039850c45246e367e194232e5ace8771f14e7 (diff)
Update popup menu structure (#1301)
* Wrap menu items in popup-menu-body * Use bodyNode instead of node * Update selector * Update _setPosition to not use items
Diffstat (limited to 'ext/bg/js/settings/dictionary-controller.js')
-rw-r--r--ext/bg/js/settings/dictionary-controller.js6
1 files changed, 3 insertions, 3 deletions
diff --git a/ext/bg/js/settings/dictionary-controller.js b/ext/bg/js/settings/dictionary-controller.js
index 941b2039..a25268d1 100644
--- a/ext/bg/js/settings/dictionary-controller.js
+++ b/ext/bg/js/settings/dictionary-controller.js
@@ -117,9 +117,9 @@ class DictionaryEntry {
}
_onMenuOpen(e) {
- const node = e.detail.menu.node;
- const showDetails = node.querySelector('.popup-menu-item[data-menu-action="showDetails"]');
- const hideDetails = node.querySelector('.popup-menu-item[data-menu-action="hideDetails"]');
+ const bodyNode = e.detail.menu.bodyNode;
+ const showDetails = bodyNode.querySelector('.popup-menu-item[data-menu-action="showDetails"]');
+ const hideDetails = bodyNode.querySelector('.popup-menu-item[data-menu-action="hideDetails"]');
const hasDetails = (this._detailsContainer !== null);
const detailsVisible = (hasDetails && !this._detailsContainer.hidden);
if (showDetails !== null) {