diff options
| author | toasted-nutbread <toasted-nutbread@users.noreply.github.com> | 2021-01-19 20:52:57 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-01-19 20:52:57 -0500 |
| commit | ccf28ed055f08d38d28b19025d10cb4e7424464b (patch) | |
| tree | 32c40a92149415c54ffd51b7868ae24d468cbaaa /ext/bg/js/settings/anki-controller.js | |
| parent | 3c51bf2a0be7c35f86d2da8c381453b95e6414bf (diff) | |
Menu refactor (#1277)
* Rename menuOpened event to menuOpen
* Rename menuClosed event to menuClose
* Rename close event
* Assign _isClosed
* Reuse event detail
* Expose PopupMenu.openMenus
* Rename and expose properties
* Add cancelable argument to close
* Update menuOpen detail
* Update menuClose detail
Diffstat (limited to 'ext/bg/js/settings/anki-controller.js')
| -rw-r--r-- | ext/bg/js/settings/anki-controller.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ext/bg/js/settings/anki-controller.js b/ext/bg/js/settings/anki-controller.js index 49bdea60..b816a47b 100644 --- a/ext/bg/js/settings/anki-controller.js +++ b/ext/bg/js/settings/anki-controller.js @@ -445,10 +445,10 @@ class AnkiCardController { this._validateField(node, index); } - _onFieldMenuClosed({currentTarget: node, detail: {action, item}}) { + _onFieldMenuClose({currentTarget: button, detail: {action, item}}) { switch (action) { case 'setFieldMarker': - this._setFieldMarker(node, item.dataset.marker); + this._setFieldMarker(button, item.dataset.marker); break; } } @@ -547,7 +547,7 @@ class AnkiCardController { } else { delete menuButton.dataset.menu; } - this._fieldEventListeners.addEventListener(menuButton, 'menuClosed', this._onFieldMenuClosed.bind(this), false); + this._fieldEventListeners.addEventListener(menuButton, 'menuClose', this._onFieldMenuClose.bind(this), false); } totalFragment.appendChild(content); |