add language select, abstract text transformations (#584)

* Copy functions from JapaneseUtil

* Remove JapaneseUtil

* Update usages of JapaneseUtil functions

* part1

* frotend done?

* fix tests

* offscreen and type complications

* add tests

* start fixing tests

* keep fixing tests

* fix tests

* Copy functions from JapaneseUtil

* Remove JapaneseUtil

* Update usages of JapaneseUtil functions

* delete pt

* renames

* add tests

* kebab-case filenames

* lint

* minor fixes

* merge

* fixes

* fix part of comments

* fix more comments

* delete unused types

* comment

* comment

* do backend

* other files

* move fetch utils to own file

* remove extra line

* add extra line

* remove unnecessary export

* simplify folder structure

* remove redundant async

* fix param type in api

* fix language index

* undo changes to cssStyleApplier

* undo changes to utilities.js

* undo changes to utilities.js

* simplify language util

* lint

* undo phantom changes to anki integration

* require textTransformations options

* explicit locale in localeCompare

* punctuate notes

* prefer early exit

* rename LanguageOptionsObjectMap

* rename to textPreprocessor

* tuple with names instead of boolean array

* safe data setting

* optional chaining

* simplify LanguageOptions

* encapsulate languages

* delete language util

* nullable language in text preprocessors controller

* rename transform to process

* remove settings

* make translation advanced again

* remove unused getTextTransformations api call

* comments

* change language types

* RIP flags

* comments

* fix tests

* lint

* Text preprocessor type changes (#10)

* Add types

* Update types

* Simplify type check

* Refactor typing and structuring of language definitions

* lint

* update translator benchmark

* undo markdown changes

* undo markdown changes

* undo markdown changes

* more merge

* simplify language controller

---------

Co-authored-by: toasted-nutbread <toasted-nutbread@users.noreply.github.com>
Co-authored-by: Darius Jahandarie <djahandarie@gmail.com>

1 files changed, 3 insertions, 12 deletions

diff --git a/benches/translator.bench.js b/benches/translator.bench.js
index 1231c31c..8b9b5118 100644
--- a/benches/translator.bench.js
+++ b/benches/translator.bench.js
@@ -20,8 +20,8 @@ import {fileURLToPath} from 'node:url';
 import path from 'path';
 import {bench, describe} from 'vitest';
 import {parseJson} from '../dev/json.js';
-import {createFindKanjiOptions, createFindTermsOptions} from '../test/utilities/translator.js';
 import {createTranslatorContext} from '../test/fixtures/translator-test.js';
+import {createFindKanjiOptions, createFindTermsOptions} from '../test/utilities/translator.js';
 
 const dirname = path.dirname(fileURLToPath(import.meta.url));
 const dictionaryName = 'Test Dictionary 2';
@@ -33,10 +33,9 @@ describe('Translator', () => {
     const {optionsPresets, tests} = parseJson(readFileSync(testInputsFilePath, {encoding: 'utf8'}));
 
     const findKanjiTests = tests.filter((data) => data.options === 'kanji');
-    const findTermTests = tests.filter((data) => data.options === 'default');
-    const findTermWithTextTransformationsTests = tests.filter((data) => data.options !== 'kanji' && data.options !== 'default');
+    const findTermTests = tests.filter((data) => data.options !== 'kanji');
 
-    bench(`Translator.prototype.findTerms - no text transformations  (n=${findTermTests.length})`, async () => {
+    bench(`Translator.prototype.findTerms - (n=${findTermTests.length})`, async () => {
         for (const data of /** @type {import('test/translator').TestInputFindTerm[]} */ (findTermTests)) {
             const {mode, text} = data;
             const options = createFindTermsOptions(dictionaryName, optionsPresets, data.options);
@@ -44,14 +43,6 @@ describe('Translator', () => {
         }
     });
 
-    bench(`Translator.prototype.findTerms - text transformations  (n=${findTermWithTextTransformationsTests.length})`, async () => {
-        for (const data of /** @type {import('test/translator').TestInputFindTerm[]} */ (findTermWithTextTransformationsTests)) {
-            const {mode, text} = data;
-            const options = createFindTermsOptions(dictionaryName, optionsPresets, data.options);
-            await translator.findTerms(mode, text, options);
-        }
-    });
-
     bench(`Translator.prototype.findKanji - (n=${findKanjiTests.length})`, async () => {
         for (const data of /** @type {import('test/translator').TestInputFindKanji[]} */ (findKanjiTests)) {
             const {text} = data;