diff options
| author | Darius Jahandarie <djahandarie@gmail.com> | 2023-03-30 15:43:24 +0900 |
|---|---|---|
| committer | Darius Jahandarie <djahandarie@gmail.com> | 2023-03-30 15:43:24 +0900 |
| commit | e4933770d0e2b021258885d04445d21527330f5d (patch) | |
| tree | 83d48c85c72a56b6aa9dd0a02db55be92744ff2b | |
| parent | 1a6d5b93f2f92dc02dada4809d43579be710d74e (diff) | |
Continue to fix playwright_comment
| -rw-r--r-- | .github/workflows/playwright_comment.yml | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/.github/workflows/playwright_comment.yml b/.github/workflows/playwright_comment.yml index 429adf3d..7e88b80e 100644 --- a/.github/workflows/playwright_comment.yml +++ b/.github/workflows/playwright_comment.yml @@ -45,14 +45,14 @@ jobs: - name: "[Comment] Couldn't download screenshots from master branch" uses: mshick/add-pr-comment@a65df5f64fc741e91c59b8359a4bc56e57aaf5b1 # pin@v2 - if: github.event_name == 'pull_request' && steps.playwright.outputs.MASTER_SCREENSHOTS_OUTCOME == 'failure' + if: steps.playwright.outputs.MASTER_SCREENSHOTS_OUTCOME == 'failure' with: message: | :heavy_exclamation_mark: Could not fetch screenshots from master branch, so had nothing to make a visual comparison against; please check the "master-screenshots" step in the workflow run and rerun it before merging. - name: "[Comment] Success: No visual differences introduced by this PR" uses: mshick/add-pr-comment@a65df5f64fc741e91c59b8359a4bc56e57aaf5b1 # pin@v2 - if: github.event_name == 'pull_request' && steps.playwright.outputs.MASTER_SCREENSHOTS_OUTCOME != 'failure' && steps.playwright.outputs.NUM_FAILED == 0 + if: steps.playwright.outputs.MASTER_SCREENSHOTS_OUTCOME != 'failure' && steps.playwright.outputs.NUM_FAILED == 0 with: message: | :heavy_check_mark: No visual differences introduced by this PR. @@ -60,7 +60,7 @@ jobs: - name: "[Comment] Warning: Visual differences introduced by this PR" uses: mshick/add-pr-comment@a65df5f64fc741e91c59b8359a4bc56e57aaf5b1 # pin@v2 - if: github.event_name == 'pull_request' && steps.playwright.outputs.MASTER_SCREENSHOTS_OUTCOME != 'failure' && steps.playwright.outputs.NUM_FAILED != 0 + if: steps.playwright.outputs.MASTER_SCREENSHOTS_OUTCOME != 'failure' && steps.playwright.outputs.NUM_FAILED != 0 with: message: | :warning: ${{ steps.playwright.outputs.NUM_FAILED }} visual differences introduced by this PR; please validate if they are desirable. |