summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDarius Jahandarie <djahandarie@gmail.com>2023-10-25 10:16:41 +0000
committerGitHub <noreply@github.com>2023-10-25 10:16:41 +0000
commitd3c916b8f742ad62e98f65e18d0dcb8a96235828 (patch)
treed764e5127eda19402e15d28126cd3e9b88ed4cd9
parentb64ca7d379e48159f98373558c339a89c01c5f6c (diff)
parentd1dda1b1d0861b78a633149af3789b2ec0668693 (diff)
Merge pull request #287 from praschke/chrome-webRequest23.10.25.0
fix: reinstate webRequest and correct the permissions docs
-rw-r--r--dev/data/manifest-variants.json16
-rw-r--r--docs/permissions.md9
-rw-r--r--ext/permissions.html16
3 files changed, 28 insertions, 13 deletions
diff --git a/dev/data/manifest-variants.json b/dev/data/manifest-variants.json
index 07c98b91..c9e7cd03 100644
--- a/dev/data/manifest-variants.json
+++ b/dev/data/manifest-variants.json
@@ -81,6 +81,7 @@
"clipboardWrite",
"unlimitedStorage",
"declarativeNetRequest",
+ "webRequest",
"scripting",
"offscreen"
],
@@ -254,15 +255,6 @@
"permissions"
],
"items": [
- "webRequest"
- ]
- },
- {
- "action": "add",
- "path": [
- "permissions"
- ],
- "items": [
"webRequestBlocking"
]
},
@@ -283,6 +275,9 @@
],
"excludeFiles": [
"sw.js",
+ "offscreen.html",
+ "js/background/offscreen.js",
+ "js/background/offscreen-main.js",
"js/dom/simple-dom-parser.js",
"lib/parse5.js"
]
@@ -331,6 +326,9 @@
],
"excludeFiles": [
"sw.js",
+ "offscreen.html",
+ "js/background/offscreen.js",
+ "js/background/offscreen-main.js",
"js/dom/simple-dom-parser.js",
"lib/parse5.js"
]
diff --git a/docs/permissions.md b/docs/permissions.md
index 10046210..57f9f0b2 100644
--- a/docs/permissions.md
+++ b/docs/permissions.md
@@ -9,8 +9,13 @@
`unlimitedStorage` is used to help prevent web browsers from unexpectedly
deleting dictionary data.
-* `webRequest` and `webRequestBlocking` _(Firefox only)_ <br>
- Yomichan uses these permissions to ensure certain requests have valid and secure headers.
+* `webRequest` <br>
+ Yomichan uses this permission to collect audio or create Anki notes using
+ [AnkiConnect](https://ankiweb.net/shared/info/2055492159).
+ It is also required to surface error information from failed requests.
+
+* `webRequestBlocking` _(Firefox only)_ <br>
+ Yomichan uses this permission to ensure certain requests have valid and secure headers.
This sometimes involves removing or changing the `Origin` request header,
as this can be used to fingerprint browser configuration.
diff --git a/ext/permissions.html b/ext/permissions.html
index 4aaef3c1..9ede7d27 100644
--- a/ext/permissions.html
+++ b/ext/permissions.html
@@ -47,12 +47,24 @@
</div>
</div>
</div></div>
+ <div class="settings-item"><div class="settings-item-inner">
+ <div class="settings-item-left">
+ <div class="settings-item-label"><code>webRequest</code></div>
+ <div class="settings-item-description">
+ <p>
+ Yomitan uses this permission to collect audio or create Anki notes using
+ <a href="https://ankiweb.net/shared/info/2055492159" target="_blank" rel="noopener noreferrer">AnkiConnect</a>.
+ It is also required to surface error information from failed requests.
+ </p>
+ </div>
+ </div>
+ </div></div>
<div class="settings-item" data-show-for-browser="firefox firefox-mobile"><div class="settings-item-inner">
<div class="settings-item-left">
- <div class="settings-item-label"><code>webRequest</code> and <code>webRequestBlocking</code></div>
+ <div class="settings-item-label"><code>webRequestBlocking</code></div>
<div class="settings-item-description">
<p>
- Yomitan uses these permissions to ensure certain requests have valid and secure headers.
+ Yomitan uses this permission to ensure certain requests have valid and secure headers.
This sometimes involves removing or changing the <code>Origin</code> request header,
as this can be used to fingerprint browser configuration.
</p>