summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authortoasted-nutbread <toasted-nutbread@users.noreply.github.com>2021-01-17 19:35:01 -0500
committerGitHub <noreply@github.com>2021-01-17 19:35:01 -0500
commitd21de9df0052d89bea09e947c312e3694cc64920 (patch)
treedc87468aa61c46f49a4105d89a7d455eac094b86
parentc875ca728f619c6e6bccbd13ceb90d898c59e53e (diff)
Update copyHostSelection to be popup-only (#1267)
-rw-r--r--ext/bg/data/options-schema.json2
-rw-r--r--ext/bg/js/options.js2
-rw-r--r--ext/bg/settings2.html2
-rw-r--r--test/test-options-util.js2
4 files changed, 4 insertions, 4 deletions
diff --git a/ext/bg/data/options-schema.json b/ext/bg/data/options-schema.json
index a140d3e9..189c8621 100644
--- a/ext/bg/data/options-schema.json
+++ b/ext/bg/data/options-schema.json
@@ -1038,7 +1038,7 @@
{"action": "addNoteTermKana", "key": "KeyR", "modifiers": ["alt"], "scopes": ["popup", "search"], "enabled": true},
{"action": "playAudio", "key": "KeyP", "modifiers": ["alt"], "scopes": ["popup", "search"], "enabled": true},
{"action": "viewNote", "key": "KeyV", "modifiers": ["alt"], "scopes": ["popup", "search"], "enabled": true},
- {"action": "copyHostSelection", "key": "KeyC", "modifiers": ["ctrl"], "scopes": ["popup", "search"], "enabled": true}
+ {"action": "copyHostSelection", "key": "KeyC", "modifiers": ["ctrl"], "scopes": ["popup"], "enabled": true}
]
}
}
diff --git a/ext/bg/js/options.js b/ext/bg/js/options.js
index deb20b00..1690efb0 100644
--- a/ext/bg/js/options.js
+++ b/ext/bg/js/options.js
@@ -712,7 +712,7 @@ class OptionsUtil {
{action: 'addNoteTermKana', key: 'KeyR', modifiers: ['alt'], scopes: ['popup', 'search'], enabled: true},
{action: 'playAudio', key: 'KeyP', modifiers: ['alt'], scopes: ['popup', 'search'], enabled: true},
{action: 'viewNote', key: 'KeyV', modifiers: ['alt'], scopes: ['popup', 'search'], enabled: true},
- {action: 'copyHostSelection', key: 'KeyC', modifiers: ['ctrl'], scopes: ['popup', 'search'], enabled: true}
+ {action: 'copyHostSelection', key: 'KeyC', modifiers: ['ctrl'], scopes: ['popup'], enabled: true}
]
};
profile.options.anki.suspendNewCards = false;
diff --git a/ext/bg/settings2.html b/ext/bg/settings2.html
index 128bd5ef..08f9ebef 100644
--- a/ext/bg/settings2.html
+++ b/ext/bg/settings2.html
@@ -3013,7 +3013,7 @@
<option value="addNoteTermKana" data-scopes="popup search">Add term note (reading)</option>
<option value="viewNote" data-scopes="popup search">View note</option>
<option value="playAudio" data-scopes="popup search">Play audio</option>
- <option value="copyHostSelection" data-scopes="popup search">Copy selection</option>
+ <option value="copyHostSelection" data-scopes="popup">Copy host window selection</option>
<option value="scanSelectedText" data-scopes="web">Scan selected text</option>
</select>
<div class="hotkey-list-item-flex-row">
diff --git a/test/test-options-util.js b/test/test-options-util.js
index c857b13f..5597dbba 100644
--- a/test/test-options-util.js
+++ b/test/test-options-util.js
@@ -455,7 +455,7 @@ function createProfileOptionsUpdatedTestData1() {
{action: 'addNoteTermKana', key: 'KeyR', modifiers: ['alt'], scopes: ['popup', 'search'], enabled: true},
{action: 'playAudio', key: 'KeyP', modifiers: ['alt'], scopes: ['popup', 'search'], enabled: true},
{action: 'viewNote', key: 'KeyV', modifiers: ['alt'], scopes: ['popup', 'search'], enabled: true},
- {action: 'copyHostSelection', key: 'KeyC', modifiers: ['ctrl'], scopes: ['popup', 'search'], enabled: true}
+ {action: 'copyHostSelection', key: 'KeyC', modifiers: ['ctrl'], scopes: ['popup'], enabled: true}
]
},
popupWindow: {