summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authortoasted-nutbread <toasted-nutbread@users.noreply.github.com>2021-05-10 18:04:08 -0400
committerGitHub <noreply@github.com>2021-05-10 18:04:08 -0400
commit376a28326b7b8f32e44c066d3b9b06ce980fa534 (patch)
tree6e6be12cc16bcfce0220de21da8fd8f64ec4f9a2
parent210f633dcc0437832cf7e3f384a02ecabe8d9063 (diff)
Fix invalid node/selectors being used in the dictionary delete process (#1658)
-rw-r--r--ext/js/pages/settings/dictionary-controller.js11
1 files changed, 2 insertions, 9 deletions
diff --git a/ext/js/pages/settings/dictionary-controller.js b/ext/js/pages/settings/dictionary-controller.js
index eca2a7d2..c8a525ce 100644
--- a/ext/js/pages/settings/dictionary-controller.js
+++ b/ext/js/pages/settings/dictionary-controller.js
@@ -624,16 +624,9 @@ class DictionaryController {
if (index < 0) { return; }
const statusFooter = this._statusFooter;
- const {node} = this._dictionaryEntries[index];
const progressSelector = '.dictionary-delete-progress';
- const progressContainers = [
- ...node.querySelectorAll('.progress-container'),
- ...document.querySelectorAll(`#dictionaries-modal ${progressSelector}`)
- ];
- const progressBars = [
- ...node.querySelectorAll('.progress-bar'),
- ...document.querySelectorAll(`${progressSelector} .progress-bar`)
- ];
+ const progressContainers = document.querySelectorAll(`#dictionaries-modal ${progressSelector}`);
+ const progressBars = document.querySelectorAll(`${progressSelector} .progress-bar`);
const infoLabels = document.querySelectorAll(`${progressSelector} .progress-info`);
const statusLabels = document.querySelectorAll(`${progressSelector} .progress-status`);
const prevention = this._settingsController.preventPageExit();