diff options
| author | Darius Jahandarie <djahandarie@gmail.com> | 2023-08-19 16:55:11 +0900 |
|---|---|---|
| committer | Darius Jahandarie <djahandarie@gmail.com> | 2023-08-20 10:24:22 +0900 |
| commit | bfe6c06c486d6fb522d252cb4660eb9f496428cc (patch) | |
| tree | e3390253a8ecbd1645a26b09007dbd55affc23d0 /.github | |
| parent | 32c1928885be4a2d822c4105216becfa90455e99 (diff) | |
Fix caching and fonts in playwright.yml
When playwright is installed (i.e., not pulled from cache), the `--with-deps` flag causes it to pull in system dependencies as well. That makes the current caching strategy incoherent, as those dependencies will not be part of the cache as defined. Causing different behavior when pulling from cache vs installing fresh.
In particular, some of the dependencies it pulls in are fonts, which causes the output of the test to change due to the available fonts changing.
In fact, fonts are the _only_ dependencies it pulls in, everything else is already present in the stock ubuntu image. So it seems fine to just remove `--with-deps` and just pull in the image. If we discover we need system deps at any point, we can use `npx playwright install-deps chromium` in a separate command to pull in those deps, and figure out an alternate caching strategy fo rthem.
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/playwright.yml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index 9397e4fa..a1135157 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -39,7 +39,7 @@ jobs: - if: ${{ steps.cache-playwright.outputs.cache-hit != 'true' }} name: Install Playwright Browsers - run: npx playwright install --with-deps chromium + run: npx playwright install chromium - name: Grab latest dictionaries from dictionaries branch uses: actions/checkout@v3 |