From 34af9213221ad5e4a5318a1d9fd89f12fca70810 Mon Sep 17 00:00:00 2001 From: WaluigiWare64 <68647953+WaluigiWare64@users.noreply.github.com> Date: Fri, 27 Aug 2021 13:54:55 +0100 Subject: ROM Info dialog - Only read 128 characters from each title Titles should be zero-terminated, but this is for additional safety --- src/frontend/qt_sdl/ROMInfoDialog.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'src/frontend/qt_sdl') diff --git a/src/frontend/qt_sdl/ROMInfoDialog.cpp b/src/frontend/qt_sdl/ROMInfoDialog.cpp index cab5f7e..a0e24e4 100644 --- a/src/frontend/qt_sdl/ROMInfoDialog.cpp +++ b/src/frontend/qt_sdl/ROMInfoDialog.cpp @@ -76,12 +76,12 @@ ROMInfoDialog::ROMInfoDialog(QWidget* parent) : QDialog(parent), ui(new Ui::ROMI ui->iconTitle->setText(QString::fromUtf16(NDSCart::Banner.EnglishTitle)); - ui->japaneseTitle->setText(QString::fromUtf16(NDSCart::Banner.JapaneseTitle)); - ui->englishTitle->setText(QString::fromUtf16(NDSCart::Banner.EnglishTitle)); - ui->frenchTitle->setText(QString::fromUtf16(NDSCart::Banner.FrenchTitle)); - ui->germanTitle->setText(QString::fromUtf16(NDSCart::Banner.GermanTitle)); - ui->italianTitle->setText(QString::fromUtf16(NDSCart::Banner.ItalianTitle)); - ui->spanishTitle->setText(QString::fromUtf16(NDSCart::Banner.SpanishTitle)); + ui->japaneseTitle->setText(QString::fromUtf16(NDSCart::Banner.JapaneseTitle, 128)); + ui->englishTitle->setText(QString::fromUtf16(NDSCart::Banner.EnglishTitle, 128)); + ui->frenchTitle->setText(QString::fromUtf16(NDSCart::Banner.FrenchTitle, 128)); + ui->germanTitle->setText(QString::fromUtf16(NDSCart::Banner.GermanTitle, 128)); + ui->italianTitle->setText(QString::fromUtf16(NDSCart::Banner.ItalianTitle, 128)); + ui->spanishTitle->setText(QString::fromUtf16(NDSCart::Banner.SpanishTitle, 128)); if (NDSCart::Banner.Version > 1) ui->chineseTitle->setText(QString::fromUtf16(NDSCart::Banner.ChineseTitle)); -- cgit v1.2.3