From 2a3a07121640cfa7fb286f0e7eb7e149c0dfabef Mon Sep 17 00:00:00 2001
From: jdp_ <42700985+jdpatdiscord@users.noreply.github.com>
Date: Mon, 28 Aug 2023 14:01:15 -0400
Subject: Reduce code stink (#1818)

CRC32.cpp:
Make table initialization compile time

DSi_NAND.cpp:
Fix file close / unmount / disk close on error
~L427: Remove redundant calls, as they are immediately rendered useless by `rem` being overwritten

NDS.cpp / FreeBIOS.h:
Remove unneeded size values in header
Remove unneeded memset's as they are initialized anyway

sha1.c / sha1.h:
Fix useless warning

Wifi.cpp:
Remove unneeded includes

DSi.cpp:
Reduce ugly casts
Deduplicate code

qt_sdl/main.cpp:
silence clang switch statement warning

qt_sdl/main.h:
fix override warnings

dolphin/BitSet.h:
use msvc extensions only when appropriate, fix broken bit set count under _WIN32
---
 src/frontend/qt_sdl/RAMInfoDialog.h | 2 +-
 src/frontend/qt_sdl/main.cpp        | 4 ++++
 src/frontend/qt_sdl/main.h          | 2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)

(limited to 'src/frontend/qt_sdl')

diff --git a/src/frontend/qt_sdl/RAMInfoDialog.h b/src/frontend/qt_sdl/RAMInfoDialog.h
index f44ae93..33afd98 100644
--- a/src/frontend/qt_sdl/RAMInfoDialog.h
+++ b/src/frontend/qt_sdl/RAMInfoDialog.h
@@ -142,7 +142,7 @@ public:
     void Stop();
 
 private:
-    void run();
+    virtual void run() override;
 
     RAMInfoDialog* Dialog;
     bool SearchRunning = false;
diff --git a/src/frontend/qt_sdl/main.cpp b/src/frontend/qt_sdl/main.cpp
index 12a9906..7f0c0ef 100644
--- a/src/frontend/qt_sdl/main.cpp
+++ b/src/frontend/qt_sdl/main.cpp
@@ -957,6 +957,8 @@ void ScreenHandler::screenHandleTablet(QTabletEvent* event)
             touching = false;
         }
         break;
+    default:
+        break;
     }
 }
 
@@ -988,6 +990,8 @@ void ScreenHandler::screenHandleTouch(QTouchEvent* event)
             touching = false;
         }
         break;
+    default:
+        break;
     }
 }
 
diff --git a/src/frontend/qt_sdl/main.h b/src/frontend/qt_sdl/main.h
index 44283a9..073a4da 100644
--- a/src/frontend/qt_sdl/main.h
+++ b/src/frontend/qt_sdl/main.h
@@ -354,7 +354,7 @@ private slots:
     void onScreenEmphasisToggled();
 
 private:
-    void closeEvent(QCloseEvent* event);
+    virtual void closeEvent(QCloseEvent* event) override;
 
     QStringList currentROM;
     QStringList currentGBAROM;
-- 
cgit v1.2.3