From ee5567708630441d8d3210e81d6e03d028fb7bbd Mon Sep 17 00:00:00 2001 From: Jesse Talavera-Greenberg Date: Fri, 18 Aug 2023 16:50:57 -0400 Subject: Assorted portability enhancements (#1800) * Introduce some Platform calls for managing dynamic libraries * Add Platform::WriteFATSectors * Introduce some Platform calls for managing dynamic libraries * Add Platform::WriteFATSectors * Change includes of "../types.h" to "types.h" - Makes it easier to directly include these headers in downstream projects * Change an include of "../Wifi.h" to "Wifi.h" * Allow CommonFuncs.cpp to compile on Android * Tidy up some logging calls - Use Platform::Log in LAN_Socket.cpp - Soften some warnings to Debug logs (since they don't necessarily represent problems) * Add Platform::EnterGBAMode - Gracefully stop the emulator if trying to enter GBA mode * Soften some logs that most players won't care about * Soften some more logs * Introduce Platform wrappers for file operations * Fix pointer spacing * Fix more style nits * Log the errno when ftruncate fails * Fix FileSeek offset argument - With an s32 offset, we couldn't access files larger than 2GB * Revise Platform::StopEmu to address feedback - Remove Platform::EnterGBAMode in favor of adding a reason to Platform::StopEmu - Also rename Platform::StopEmu to Platform::SignalStop - Add an optional argument to NDS::Stop - Use the new argument everywhere that the console stops itself * Rename FileGetString to FileReadLine - It conveys the meaning better * Rename FileSeekOrigin::Set to Start - It conveys the meaning better * Change definition of FileGetString to FileReadLine - Oops, almost forgot it * Rename FlushFile to FileFlush - To remain consistent with the other File functions * Add a FileType usage * Fix line break in FileSeekOrigin * Document Platform::DeInit * Clarify that StopReason::Unknown doesn't always mean an error * Move and document FileType::HostFile * Remove Platform::OpenDataFile - Nothing currently uses it * Refactor Platform::OpenFile and Platform::OpenLocalFile to accept a FileMode enum instead of a string - The enum is converted to fopen flags under the hood - The file type is used to decide whether to add the "b" flag - Some helper functions are exposed for the benefit of consistent behavior among frontends - Equivalent behavior is maintained * Fix a tab that should be spaces * Use Windows' 64-bit implementations of fseek/ftell * Move Platform::IsBinaryFile to Platform.cpp - It could vary by frontend * Remove an unused FileType * Rename an enum constant * Document various Platform items * Use Platform::DynamicLibrary to load libandroid - And clean it up at the end * Fix a typo * Pass the correct filetype to FATStorage - Since it can be used for DSI NAND images or for SD cards * Remove Platform::FileType --- src/GPU2D.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/GPU2D.cpp') diff --git a/src/GPU2D.cpp b/src/GPU2D.cpp index 9d616d3..d5df992 100644 --- a/src/GPU2D.cpp +++ b/src/GPU2D.cpp @@ -220,7 +220,7 @@ u8 Unit::Read8(u32 addr) case 0x04D: return 0; } - Log(LogLevel::Warn, "unknown GPU read8 %08X\n", addr); + Log(LogLevel::Debug, "unknown GPU read8 %08X\n", addr); return 0; } @@ -249,7 +249,7 @@ u16 Unit::Read16(u32 addr) case 0x06C: return MasterBrightness; } - Log(LogLevel::Warn, "unknown GPU read16 %08X\n", addr); + Log(LogLevel::Debug, "unknown GPU read16 %08X\n", addr); return 0; } @@ -366,7 +366,7 @@ void Unit::Write8(u32 addr, u8 val) return; } - Log(LogLevel::Warn, "unknown GPU write8 %08X %02X\n", addr, val); + Log(LogLevel::Debug, "unknown GPU write8 %08X %02X\n", addr, val); } void Unit::Write16(u32 addr, u16 val) -- cgit v1.2.3