From 65c27c5c288818193d7957ae3549d687ccafaec5 Mon Sep 17 00:00:00 2001 From: StapleButter Date: Sat, 29 Dec 2018 23:32:58 +0100 Subject: fix potential crashes in input config dialog when setting joystick buttons, by using uiQueueMain() how could I not think of this? GTK is not thread safe. --- src/libui_sdl/DlgInputConfig.cpp | 35 +++++++++++++++++------------------ 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/src/libui_sdl/DlgInputConfig.cpp b/src/libui_sdl/DlgInputConfig.cpp index 287d7e3..0fc7f4a 100644 --- a/src/libui_sdl/DlgInputConfig.cpp +++ b/src/libui_sdl/DlgInputConfig.cpp @@ -165,6 +165,21 @@ int OnAreaKeyEvent(uiAreaHandler* handler, uiArea* area, uiAreaKeyEvent* evt) return 1; } +void FinishJoyMapping(void* param) +{ + InputDlgData* dlg = (InputDlgData*)param; + int id = dlg->pollid & 0xFF; + + char keyname[16]; + JoyMappingName(dlg->joymap[id], keyname); + uiButtonSetText(dlg->pollbtn, keyname); + uiControlEnable(uiControl(dlg->pollbtn)); + + dlg->pollid = -1; + + uiControlSetFocus(uiControl(dlg->pollbtn)); +} + Uint32 JoyPoll(Uint32 interval, void* param) { InputDlgData* dlg = (InputDlgData*)param; @@ -184,15 +199,7 @@ Uint32 JoyPoll(Uint32 interval, void* param) if (SDL_JoystickGetButton(joy, i)) { dlg->joymap[id] = i; - - char keyname[16]; - JoyMappingName(dlg->joymap[id], keyname); - uiButtonSetText(dlg->pollbtn, keyname); - uiControlEnable(uiControl(dlg->pollbtn)); - - dlg->pollid = -1; - - uiControlSetFocus(uiControl(dlg->pollbtn)); + uiQueueMain(FinishJoyMapping, dlg); return 0; } } @@ -206,15 +213,7 @@ Uint32 JoyPoll(Uint32 interval, void* param) else blackhat = 0x8; dlg->joymap[id] = 0x100 | blackhat; - - char keyname[16]; - JoyMappingName(dlg->joymap[id], keyname); - uiButtonSetText(dlg->pollbtn, keyname); - uiControlEnable(uiControl(dlg->pollbtn)); - - dlg->pollid = -1; - - uiControlSetFocus(uiControl(dlg->pollbtn)); + uiQueueMain(FinishJoyMapping, dlg); return 0; } -- cgit v1.2.3